This repository has been archived by the owner on Aug 27, 2018. It is now read-only.
Fix shouldComponentUpdate check #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug whereby a component where the props haven't changed would always re-render regardless of the state having changed or not.
There already exists a check that only calls the underlying
setStateif the state has genuinely changed, but this failed to cover the situation where the component itself is re-rendered by its parent component and its props have not changed). In this case,shouldComponentUpdateis still called. Where a component had only state and no props, we were unconditionally returningtrue. So we need in effect a double safety net to check the state again (no real cost here)