Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devices][Mellanox] create sai.xml for Mellanox-SN3800-D112-C8 #4

Closed
wants to merge 1 commit into from

Conversation

mykolaf
Copy link
Owner

@mykolaf mykolaf commented Mar 3, 2020

Signed-off-by: Mykola Faryma [email protected]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@mykolaf mykolaf changed the title [devices][Mellanox] create sai.xml for MSN3800-D112-C8 [devices][Mellanox] create sai.xml for Mellanox-SN3800-D112-C8 Mar 3, 2020
Copy link

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the name to be different? why?

@mykolaf
Copy link
Owner Author

mykolaf commented Mar 4, 2020

do we need the name to be different? why?

I guess there is no technical need, but it makes it clear that this is not the default sai_xml for 3800 without examining the file contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants