Fix get_inner_columns_with_types trailing space #385

mymarilyn · Aug 8, 2024 · 29b9d91 · 29b9d91
1 parent 1e4291c
commit 29b9d91
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/clickhouse_driver/columns/util.py b/clickhouse_driver/columns/util.py
@@ -37,12 +37,13 @@ def get_inner_columns(spec):
 
 
 def get_inner_columns_with_types(spec):
+    spec = spec.strip()
     brackets = 0
     prev_comma = 0
     prev_space = 0
 
     columns = []
-    for i, x in enumerate(spec + ','):
+    for i, x in enumerate(spec.strip() + ','):
         if x == ',':
             if brackets == 0:
                 columns.append((

diff --git a/tests/test_util.py b/tests/test_util.py
@@ -0,0 +1,8 @@
+from clickhouse_driver.columns.util import get_inner_columns_with_types
+
+
+def test_get_inner_columns_with_types_empty_spaces():
+    assert (
+        get_inner_columns_with_types('\n test String\n ') ==
+        [('test', 'String')]
+    )