Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 12 actions are deprecated #28

Closed
biojppm opened this issue Nov 21, 2022 · 3 comments
Closed

Node.js 12 actions are deprecated #28

biojppm opened this issue Nov 21, 2022 · 3 comments

Comments

@biojppm
Copy link

biojppm commented Nov 21, 2022

When the action runs, Github issues this warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: mymindstorm/setup-emsdk@v11
@mattip mattip mentioned this issue Dec 2, 2022
Closed
@jeetiss jeetiss mentioned this issue Dec 11, 2022
Closed
@mmoskal
Copy link

mmoskal commented Jan 12, 2023

@mymindstorm could this be merged and tagged? right now I have semantic-release build failing since it doesn't like node14 being installed via setup-emsdk

@mymindstorm
Copy link
Owner

Thanks for the ping @mmoskal , I've not had much time for open-source work due to life changes a year or two ago.

I've pushed v12 via ed0d39a, which should resolve this issue. Although, I still need to go and update @actions/* and ava. Please let me know if that resolves the issues with y'alls repos.

@mmoskal
Copy link

mmoskal commented Jan 14, 2023

Thank you!

It looks like the node 14.18.2 is installed by emsdk install script itself not the action. We were able to work around the issue by running setup-node action (with node 18) after setup-emsdk and before semantic-release

@umarcor umarcor mentioned this issue Mar 26, 2023
Merged
myfreeer added a commit to myfreeer/cglm that referenced this issue Jun 14, 2023
@myfreeer
ci: update mymindstorm/setup-emsdk to v12
02b9dc0 
Github is using node16 by default for actions, so it might worth to update this to latest version supporting node16 by default.

See also:
* <mymindstorm/setup-emsdk#28>
* <https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/>
* <https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default>
@myfreeer myfreeer mentioned this issue Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update node and ncc jeetiss/setup-emsdk
3 participants
@biojppm @mmoskal @mymindstorm