Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when run on ubuntu #30

Closed
connorjclark opened this issue Dec 16, 2022 · 2 comments
Closed

Error when run on ubuntu #30

connorjclark opened this issue Dec 16, 2022 · 2 comments

Comments

@connorjclark
Copy link

It seems like it's downloading the mac version of the binaries somehow.

https://github.com/connorjclark/ZeldaClassic/actions/runs/3717330481/jobs/6304571033#step:9:11

emscripten-core/emscripten#8622 (comment)

When run on macos jobs it works fine tho

@connorjclark
Copy link
Author

connorjclark commented Dec 16, 2022

Oh, since I was going from mac->ubuntu and was providing a cache key, I accidentally got the cached version of mac for the linux job.

https://github.com/mymindstorm/setup-emsdk/blob/master/src/main.ts#L30

Maybe the os should be appended to the cache key (even if provided) to prevent this footgun?

This fixed my problem:

    actions-cache-folder: "emsdk-cache-${{ runner.os }}-${{ runner.arch }}"

mymindstorm added a commit that referenced this issue Jan 13, 2023
Fixes Error when run on ubuntu #30
@mymindstorm
Copy link
Owner

@connorjclark thanks for this, I've pushed a release to implement your suggestion via ab889da.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants