Makefile.am: Fix underlinking

[sardemff7]

No description provided.

[achadwick]

Does ordering matter here?

[sardemff7]

Yes. Try adding -Wl,--no-undefined to your `LDFLAGS’ and test with and without this patch. :-)

[QuLogic]

Strictly speaking, shouldn't $(GEGL_LIBS) be last?

[sardemff7]

Oh, strictly speaking, yes.

[achadwick]

Hi there - what underlinking problem does this solve? We already use LIBS = @LIBS since 78ac562 and -no-undefined since bf3cd0c.

$ ldd -r .libs/libmypaint.so >/dev/null
[no output]

But that's only the "direct" case, of course.

[sardemff7]

Here are the logs:
without the patch
with the first part (without the reordering)
I use -Wl,--as-needed too, and note that -no-undefined is not very strong, libtool often ignore it.

You’re right about $(LIBS) but it is good practice to avoid putting everything in that an relying on the default values. *_LIBADD (and not *_LIBS, nor *_LDADD since you are building libs here) is cleaner.

Also, LIBS contains -lm as you use AC_SEARCH_LIBS.

I started an Autotools usage cleanup, but you do use a lot of shortcuts, so a simple fix will do for now. :-)