Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MYR-881] Autogenerate password and return gun public and ePublic keys in friends list #167

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

rei-gun
Copy link
Contributor

@rei-gun rei-gun commented Oct 6, 2021

Title

  • JIRA Issue ID (preferably only ONE parent issue, put subtask IDs in the Description)
  • Multiple JIRA Issue IDs? Are you sure your PR isn't too big? Can you rebase your commits to new branches so there's only 1 issue ID?
  • Is your title relatable to the JIRA issue?
  • Title <= 100 characters

Description

  • src/tests/integration/controllers/user.controller.integration.ts
    • added test for POST /users
  • src/controllers/user.controller.ts
    • added password generation via hash.
    • I think the salt needs to be manually set and saved in our .env file because it's using default salt atm
    • the hashing should be done in UserRepository's create() function instead of the controller

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Builds and runs on Windows
  • Builds and runs on MacOS
  • Builds and runs on Linux
  • Builds and runs on Docker (Linux)
  • Unit tests?
  • Integration tests?
  • End-to-end (E2E) tests?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • Have you added yourself as the Assignee?
  • Have you added 1 or more leads as the Reviewer?
  • Have you chosen 1-2 of the following labels?
    • Feature
    • Bug
    • Refactor
    • Test
    • Documentation

@rei-gun rei-gun force-pushed the autogen-password branch 2 times, most recently from f6e32f1 to 647939c Compare October 7, 2021 06:13
@irmannmal irmannmal merged commit 6576197 into myriadsocial:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants