Modal, a play in 3 acts #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this in a story. We may want to push this down into the NewNote modal
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/Gf54Mm1wUVgEtuhjwXEEdn7nVfkP |
Make this look and feel great using the example at https://tailwindui.com/components/application-ui/overlays/modals
ianconsolata
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
This looks great and doesn't conflict with what I am working on much at all. Should I merge this whole thing? Squash and merge? Or should I just cherry-pick out a single commit, and if so which one? It all looks fine to me, but the description seems to indicate I should only merge part of it.
|
if it doesn't conflict with your stuff I'm just gonna merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Act 1: A story about how to use Dialog for modals
Act 2: In which we add a Dialog to the Header, and leave some things incomplete
Act 3: A halfhearted attempt to use Dialog for the existing New Note Creation modal
Act (ie, commit) 3 in particular maybe shouldn't be merged, but I wanted to test Dialog on real code and figured I'd throw this up there
The first commit should be good to go, and the second commit is worth merging if it doesn't conflict with what you've been working on @ianconsolata
EDIT: Act 4 dropped late and is all fluff no content, typical Hollywood. Looks great though, and probably also worth merging, by cherry-pick if needed