-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal Creator for Bookmarks, Images, and Files #35
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/HAnhk7d9vJ7VjqAoyGQTyo9Ag33N |
@travis Why do you use |
we chatted in Slack but to memorialize - I think this was to avoid potential duplicate filenames. might not actually be an issue, and we could always append a unique id to the filename to get the best of both worlds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good! I'd like to start using that new model logic for note saving too, particularly in createOrUpdateConceptIndex:
Line 76 in ce8424b
export function createOrUpdateConceptIndex( |
Right adding metadata to a concept requires adding it there so that it doesn't get lost on save, feels fragile! Definitely don't need to get this change in now, just flagging so we can sync on this data model stuff soon.
components/modals/NewFile.jsx
Outdated
const onSubmit = async () => { | ||
if (file) { | ||
const fileUrl = `${fileContainerUri}${file.name}`; | ||
console.log('url', fileUrl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console log
This is to support non-notes (like Links) in the Dashboard view
2ee9ddc
to
06c94b4
Compare
These do not show up in the dashboard UI yet (you can add them, they show up in the index, but everything that does not have a note is filtered out.