upgrade plate to latest version #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/8kJVyRcNo8g9uyqkYZjcMMEViofw |
copy formatting rules from https://github.com/udecode/plate/tree/main/docs/src/live/config/autoformat we may want to tweak these, but they feel pretty slick in my testing
A bit of a change in the UX here - triggering concepts on single [ - so I want to run this through staging to see how it feels.
this allows people to create tags, mentions, concepts on the fly
travis
changed the title
the onMouseDown event was bubbling up and triggering the headlessui dialog's hide-on-click-outside detector - prevent propagation to fix this
make it clear what you are adding
right now if you have text above and below a link on a single line, the link will expand to include the items on previous lines. this is not desired.
I hate this so here's an alternative that also de-emphasizes the double square brackets
ianconsolata
approved these changes
Nov 30, 2021
| P.createComboboxPlugin(), | ||
| P.createMentionPlugin({ trigger: '@', pluginKey: 'mention' }), | ||
| P.createMentionPlugin({ trigger: '#', pluginKey: 'tag' }), | ||
| P.createMentionPlugin({ trigger: '[', pluginKey: 'concept' }), |
There was a problem hiding this comment.
can you use the appropriate constants here rather than the strings?
| const currentComboboxText = comboboxStore.get.text() | ||
| return useMemo(() => { | ||
| return (names ? Array.from(new Set([...names, currentComboboxText])) : [currentComboboxText]).map(toMentionable) | ||
| }, [names, currentComboboxText]) |
There was a problem hiding this comment.
I think you could wrap all the text property in brackets / prefix it with the trigger in this list to have them show up with the formatting in the dropdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.