Multiple issues doing a clean UK import (using vagrant)

[torotil]

I have multiple issues trying to do a new import of all the current UK data following this guide. Currently I'm stuck at

./manage.py mapit_UK_scilly --allow-no-location-postcodes \
   --allow-terminated-postcodes ../data/ONSPD/Data/ONSPD_MAY_2016_UK.csv

Which fails with mapit.models.DoesNotExist: Postcode matching query does not exist.

---

On my journey there I already had to fix several issues.

1. Vagrant doesn't find the VagrantFile: Renamed to Vagrantfile and now it works. I also had to increase the memory a bit to be able to run the import.
2. mapit_UK_import_osni - The argument types for the --*-srid arguments are all strings. They should be callables. Removing the quotes helped.
3. mapit_UK_import_onspd is missing the call to super().add_arguments().

[dracos]

Sorry about that, and thanks for tracking those things down. For the main issue, it looks to be that the documentation has got you to import only the live ONSPD postcodes, but the Scilly line is telling you to also look at postcodes without location or dead postcodes, which then aren't present in the database, hence the error. This would actually be solved better by #219 (which then wouldn't care which postcodes you had imported or not), but for now I think you can just either import those no-location/terminated postcodes in your main import, or not include them in the Scilly line.

Will go and fix the things you raised now :) PR at #265

[torotil]

Great the PR includes all the issues I've had and more.