Add South Africa as a core country supported by MapIt #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some minor comments, otherwise ⛳ |
We're shortly going to add another country that we don't currently have postcode data for, and currently the test for whether that's the case is just "country == 'Global'" in the templates - that can't be easily extended because of the limitations on condidations in Django templates and it would also be bad to have to repeat that logic everywhere. Instead, this commit adds a settings variable POSTCODES_AVAILABLE and it's also added to the country context processor so that it's available in templates as postcodes_available.
This allows for a nicer default as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some interest in an independent MapIt being set up for South Africa,
rather than just the private one mounted in the People's Assembly site.
This pull request adds support for South Africa as a core country, in the same
way as Norway, the UK or Global.
For the moment, there's an instance you can try out here: