Add django 1.8 support #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow 1.8 to fail as it's not currently out.
It's no longer needed.
One gotcha - if we've been called via deal_with_POST (for very long URLs), then move POST into GET before handling the request.
urlpatterns as a list has worked since 1.4.
This allows the same templates to work in anything from 1.4 upwards.
Use Django's render() shortcut rather than our own; create a render_to_string patch that uses request/context appropriately; stub out Context() when not needed; add TEMPLATES setting.
dracos
force-pushed
the
add-django-1.8-testing
branch
from
a5cd6ef
to
9212c49
Compare
|
Incidentally, why are you preferring |
|
I've added a few comments or questions, but otherwise this looks good to me. |
|
"why are you preferring get_version()" – |
This was added in Django 1.7 in order to invalidate sessions on password change.
Remove Django/South from packages files, and put requirements in setup.py rather than reqirements.txt.
dracos
force-pushed
the
add-django-1.8-testing
branch
from
3e633e1
to
87dacbc
Compare
|
Merged in fc7f2eb with Version 1.3 commit added on top separately to fix typos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And tidy up bits for some future proofing.