Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes after a fresh import #225

Closed
wants to merge 3 commits into from

Conversation

symroe
Copy link
Contributor

@symroe symroe commented Feb 16, 2016

Here are 3 commits I made whilst importing the data from scratch.

Patch incorrect IDs in first-gss control file is because patch_boundary_line is needed on the initial import, however the patch function was missing from the first-import file.

Open CSV files with the correct encoding might just be an issue with python 3, but I think it's backwards compatible.

And the last one is just a small pep8 update that I thought should be it's own commit.

Without this, the initial Boundary-Line import (as laid out in the documentation) fails due to the incorrect ID that the patch fixes.
@dracos dracos added the Current label Feb 16, 2016
@dracos
Copy link
Member

dracos commented Feb 19, 2016

Patch IDs - ah, because if it's a first import you can't use the 2015-10 control file as is, I see. As these patches might only apply to the 2015-10 edition but will always be correct, it's okay to have them in the first use file. It would be good if this could be edited to state the edition of Boundary-Line that these patch lines exist for. Now fixed on master

CSV - sure, happy to add this, but this is a very old one off script from 2010, the data it uses won't have been updated since then; just checking you realise that.

Break lines - We have a setup.cfg in the repository root that sets our max line length to 119, so this isn't necessary, thanks :)

@dracos dracos added Reviewed and removed Current labels Mar 1, 2016
@dracos
Copy link
Member

dracos commented May 6, 2016

First fixed differently, second cherry picked, third unnecessary, so this is done, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants