Use reverse so more redirects work when MapIt is mounted on a subpath #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
If you've included MapIt in another Django project, e.g. with:
urlpatterns += patterns('',
(r'^mapit/', include('mapit.urls')),
)
... then some of the views that returned a redirect to a URL
constructed with string formatting would redirect to a path
that didn't include the 'mapit/' prefix. If these paths are
constructed with reverse() instead, it works properly.
This also introduces some new URL pattern names, so the URL
patterns can be referred to more concisely.
mhl
force-pushed
the
more-redirects-using-reverse
branch
from
8a643aa
to
d692d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you've included MapIt in another Django project, e.g. with:
... then some of the views that returned a redirect to a URL
constructed with string formatting would redirect to a path
that didn't include the 'mapit/' prefix. If these paths are
constructed with reverse() instead, it works properly.
This also introduces some new URL pattern names, so the URL
patterns can be referred to more concisely.