Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversing of ONS coded polygon URLs #236

Merged
merged 1 commit into from
May 25, 2016
Merged

Fix reversing of ONS coded polygon URLs #236

merged 1 commit into from
May 25, 2016

Conversation

dracos
Copy link
Member

@dracos dracos commented May 6, 2016

No description provided.

d692d27 broke the reversing of polygon (kml/geojson/wkt) area
URLs when given with an ONS or GSS code.
@mhl
Copy link
Contributor

mhl commented May 25, 2016

Looks good to me 👍

The only comment I have is incidental (i.e. not actually to do with the lines that have been changed) but I think it would be easier to read the area_code_lookup function if area_code were renamed to area_code_type and then the area_id parameter were renamed to area_code.

@mhl
Copy link
Contributor

mhl commented May 25, 2016

(and sorry about missing this in my previous PR...)

@dracos dracos merged commit 394890d into master May 25, 2016
@dracos dracos removed the Reviewing label May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants