[UK] Improved postcode validation. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
improved-postcode-validation
branch
from
d2a8f4d
to
5b909cf
Compare
dracos
force-pushed
the
improved-postcode-validation
branch
from
5b909cf
to
34f8c20
Compare
Switch to using the uk-postcode-utils package which is quicker, and includes a missing "P" in the third character list.
dracos
force-pushed
the
improved-postcode-validation
branch
from
34f8c20
to
bebd65f
Compare
stevenday
approved these changes
Oct 13, 2016
|
It seemed like you might well not want to treat those as valid, or have a different list, so left the library to accept whatever "extra" you decided. It could be a list stored there, I guess, but didn't seem worth it. |
I dunno, it's exactly the sort of thing I'd be delighted to find out a postcode library had built in. Obviously it might need some options or something - I'll make a ticket on postcodeutils. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much quicker, and includes a missing "P" in the third character list. Thanks to Andy Gimblett for suggesting these changes to the https://github.com/mysociety/uk-postcode-utils package.