UI refresh #280
UI refresh #280
Conversation
mapit_it/templates/mapit/base.html
Outdated
| @@ -1,88 +1,4 @@ | |||
| {% load static from staticfiles %} | |||
| {% extends "mapit/base.html" %} | |||
There was a problem hiding this comment.
Drive-by: This won't work I'm afraid because it's the same template being overridden.
Put the description in a separate template and then override that?
There was a problem hiding this comment.
The only reason I'm overriding base.html here is to insert the translated page description. Could we just upload the translation via Transifex instead, and then the override wouldn't even be required?
There was a problem hiding this comment.
It already is trans, so yes,i don't think this is necessary at all.
| margin-top: 0; | ||
| } | ||
|
|
||
| .mapit-copyright { |
There was a problem hiding this comment.
Could we keep the copyright text being a bit smaller? :)
| @media (min-width: 60em) { | ||
| float: right; | ||
| clear: none; | ||
| width: 28.75em; |
There was a problem hiding this comment.
I quite liked the two columns of text output on an area page.
| input[type="text"] { | ||
| @extend .form-control; | ||
| @extend .form-control--inline; | ||
| text-transform: uppercase; |
There was a problem hiding this comment.
On Global, "LATITUDE,LONGITUDE" does not fit.
| // Creates area_level_1 to area_level_10 | ||
| // optionally add to list items to add indentation suggesting hierarchy | ||
|
|
||
| @while $area_level > 0 { |
There was a problem hiding this comment.
It would be a shame to lose this (which indents the area lists on e.g. http://global.mapit.mysociety.org/point/4326/8.55,47.366667.html).
|
One other thing, do you think the line between sections of the docs might be a bit faint? I can only just see it on my monitor :) |
zarino
force-pushed
the
ui-refresh
branch
2 times, most recently
from
bab8048
to
29d097d
Compare
This includes mysociety-docs-theme as a submodule, to build on the standard theme we use for other documentation sites.
This brings the generic UI improvements from mysociety/mapit.mysociety.org#29 into mapit core.
Works really well with the latest version of mysociety/mapit.mysociety.org#32, but needs testing in the other mapit cobrands (like global, and italy).