🐛 fix file-extension-in-import for scoped packages (fixes #160)

mysticatea · May 4, 2019 · 2f756ec · 2f756ec
1 parent 11d2d41
commit 2f756ec
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rules/file-extension-in-import.js b/lib/rules/file-extension-in-import.js
@@ -8,6 +8,7 @@ const path = require("path")
 const fs = require("fs")
 const getImportExportTargets = require("../util/get-import-export-targets")
 const getTryExtensions = require("../util/get-try-extensions")
+const packageNamePattern = /^(?:@[^/]+\/)?[^/]+$/u
 
 /**
  * Get all file extensions of the files which have the same basename.
@@ -69,7 +70,7 @@ module.exports = {
 
         function verify({ filePath, name, node }) {
             // Ignore if it's not resolved to a file or it's a bare module.
-            if (!filePath || !/[/\\]/u.test(name)) {
+            if (!filePath || packageNamePattern.test(name)) {
                 return
             }
 

diff --git a/tests/lib/rules/file-extension-in-import.js b/tests/lib/rules/file-extension-in-import.js
@@ -32,6 +32,10 @@ new RuleTester({
             filename: fixture("test.js"),
             code: "import 'eslint'",
         },
+        {
+            filename: fixture("test.js"),
+            code: "import '@typescript-eslint/parser'",
+        },
         {
             filename: fixture("test.js"),
             code: "import 'xxx'",