add new rule #4
Open
add new rule #4
+336
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mytestopia
requested changes
Sep 30, 2024
flake8_vedro/visitors/context_checkers/assert_context_checker.py
Outdated
Show resolved
Hide resolved
mytestopia
reviewed
Oct 7, 2024
mytestopia
reviewed
Oct 11, 2024
Comment on lines
18
to
23
| for line in context.context_node.body: | ||
| if isinstance(line, ast.Assert): | ||
| has_assert = True | ||
| break | ||
|
|
||
| has_assert = self._has_assert_in_block(context.context_node.body) |
There was a problem hiding this comment.
you have a loop for every line in context.context_node.body, for each line there's a call of method _has_assert_in_block for the whole context.context_node.body
are you sure that it's a good solution?
mytestopia
reviewed
Oct 17, 2024
|
|
||
| return errors | ||
|
|
||
| def _has_assert_in_block(self, block: List[ast.stmt]): |
There was a problem hiding this comment.
missing typing for return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new optional rule to the linter, the presence of which is subsequently asserted in contexts marked by the @vedro.context decorator. It is disabled by default.