Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh-net)!: Make netcheck::Client !Clone #2716

Merged
merged 3 commits into from
Sep 9, 2024

Commits on Sep 6, 2024

  1. refactor(iroh-net): Make netcheck::Client !Clone

    netcheck::Client owns the actor task and when dropped it will abort
    the actor task.  Making a struct owning a task Clone means it is easy
    to lose track of who should be owning a task like this.  I now believe
    each task should have a clear supervisor/owner in charge of it.
    
    This cleans up the multiple-ownership of the netcheck::Client, which
    is just a small step into this direction.  Later on, for e.g. #2647,
    more supervision will be added.  But small changes are good.
    flub committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    253e5ae View commit details
    Browse the repository at this point in the history
  2. fixup docs

    flub committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ae8bc54 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. fixup wording

    flub committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    852f324 View commit details
    Browse the repository at this point in the history