Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add full help text for lookup, connect, get, p2p, and iroh commands #348

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

ramfox
Copy link
Contributor

@ramfox ramfox commented Oct 14, 2022

No description provided.

@ramfox ramfox self-assigned this Oct 14, 2022
@ramfox ramfox added docs Improvements or additions to documentation c-ctl labels Oct 14, 2022
@ramfox ramfox added this to the v0.1.0 milestone Oct 14, 2022
iroh/src/p2p.rs Outdated
pub struct P2p {
#[clap(subcommand)]
command: P2pCommands,
}

#[derive(Subcommand, Debug, Clone)]
pub enum P2pCommands {
#[clap(about = "Connect to a peer")]
#[clap(after_help = "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we move these into constants defined in a separate file, like help.rs. Makes it harder to follow the code with these large breaks

@b5 b5 merged commit b14a7a8 into main Oct 15, 2022
@b5 b5 deleted the ramfox/lookup_connect_text branch October 15, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants