feat: initial support for c bindings #948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iroh-ffi/.gitignore
Outdated
| @@ -0,0 +1,4 @@ | |||
| /target | |||
| /Cargo.lock | |||
There was a problem hiding this comment.
can we make this part of the workspace please, then you shouldn't need these two lines
iroh-ffi/Cargo.toml
Outdated
| version = "0.1.0" | ||
| edition = "2021" | ||
| publish = false | ||
| rust-version = "1.64" |
2 tasks
* chore(ci): add ffi bindings to CI * bump * fix diff detection * fix * check in iroh.h * disable ffi doctests * fix * fix output status of compare
fixes for swift building
Closed
|
closing in favor of #1321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unclear on if this is allowed in our primary repo, but I personally think the c bindings should be here. Thoughts welcome.