* remove exit() statement that exists from f8939b8, and now being u…

…nnecessary due to 8089d16 @ `App\Helper->abortAPI()` * suppress or fix some violations of phpmd rules @ be
n0099 · Sep 15, 2024 · fdeea75 · fdeea75
1 parent 2766c30
commit fdeea75
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/be/app/Helper.php b/be/app/Helper.php
@@ -95,7 +95,6 @@ public static function abortAPI(int $errorCode): never
             throw new \InvalidArgumentException('Given error code doesn\'t existed');
         }
         response()->json(compact('errorCode', 'errorInfo'), $statusCode)->throwResponse();
-        exit;
     }
 
     /**

diff --git a/be/app/Http/PostsQuery/BaseQuery.php b/be/app/Http/PostsQuery/BaseQuery.php
@@ -323,6 +323,7 @@ static function (string $postIDName) use ($result): array {
      * @param Collection<int, SubReply> $subReplies
      * @phpcs:ignore Generic.Files.LineLength.TooLong
      * @return Collection<int, Collection<string, mixed|Collection<int, Collection<string, mixed|Collection<int, Collection<string, mixed>>>>>>
+     * @SuppressWarnings(PHPMD.CamelCaseParameterName)
      */
     public static function nestPostsWithParent(
         Collection $threads,

diff --git a/be/app/Http/PostsQuery/IndexQuery.php b/be/app/Http/PostsQuery/IndexQuery.php
@@ -13,6 +13,9 @@
 
 class IndexQuery extends BaseQuery
 {
+    /**
+     * @SuppressWarnings(PHPMD.ElseExpression)
+     */
     public function query(QueryParams $params, ?string $cursor): self
     {
         /** @var array<string, mixed> $flatParams key by param name */

diff --git a/be/app/Http/PostsQuery/QueryParams.php b/be/app/Http/PostsQuery/QueryParams.php
@@ -70,6 +70,9 @@ protected function getParamsIndexByName(string $name): array
         return array_keys(array_filter($this->params, static fn($p) => $p->name === $name));
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ElseExpression)
+     */
     public function addDefaultValueOnUniqueParams(): void
     {
         $uniqueParamsDefaultValue = [

diff --git a/be/app/Http/PostsQuery/SearchQuery.php b/be/app/Http/PostsQuery/SearchQuery.php
@@ -156,12 +156,9 @@ private static function applyTextMatchParamOnQuery(
                     trim("$not LIKE"),
                     $subParams['matchBy'] === 'implicit' ? "%$keyword%" : $keyword
                 );
-            if ($subParams['spaceSplit']) { // split multiple search keyword by space char
-                foreach (explode(' ', $value) as $splitedKeyword) {
-                    $addMatchKeyword($splitedKeyword);
-                }
-            } else {
-                $addMatchKeyword($value);
+            // split multiple search keyword by space char when $subParams['spaceSplit'] == true
+            foreach ($subParams['spaceSplit'] ? explode(' ', $value) : [$value] as $keyword) {
+                $addMatchKeyword($keyword);
             }
         });
     }