Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) #5953

Merged
merged 7 commits into from
Apr 12, 2023
Merged

refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) #5953

merged 7 commits into from
Apr 12, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Apr 11, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 88.67% and project coverage change: +0.13 🎉

Comparison is base (725393d) 17.55% compared to head (b6e1031) 17.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5953      +/-   ##
==========================================
+ Coverage   17.55%   17.69%   +0.13%     
==========================================
  Files        2500     2519      +19     
  Lines      114430   114618     +188     
  Branches    17858    17859       +1     
==========================================
+ Hits        20092    20279     +187     
  Misses      93744    93744              
- Partials      594      595       +1
Impacted Files Coverage Δ
packages/cli/src/InternalHooks.ts 6.77% <0.00%> (-0.11%) ⬇️
packages/cli/src/WaitTracker.ts 0.00% <ø> (ø)
packages/cli/src/WorkflowExecuteAdditionalData.ts 12.34% <ø> (ø)
packages/cli/src/WorkflowRunnerProcess.ts 0.00% <0.00%> (ø)
packages/cli/src/api/e2e.api.ts 0.00% <0.00%> (ø)
packages/cli/src/api/workflowStats.api.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/export/credentials.ts 0.00% <0.00%> (ø)
packages/cli/src/commands/import/credentials.ts 0.00% <0.00%> (ø)
packages/cli/src/controllers/auth.controller.ts 76.92% <ø> (ø)
packages/cli/src/controllers/me.controller.ts 89.77% <ø> (ø)
... and 44 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy requested a review from krynble April 11, 2023 19:02
@RicardoE105
Copy link
Contributor

RicardoE105 commented Apr 11, 2023 •
edited
Loading

@netroy was testing it with MySQL and got this message in the console when I executed a workflow (only one webhook node). In master the workflow runs fine.

typestack/typedi#636

image

@RicardoE105
Copy link
Contributor

RicardoE105 commented Apr 12, 2023 •
edited
Loading

I looked, and we cannot get an InternalHooks instance without initializing the database. Created a PR to test it, and it removes the issue (or at least looks like it)

krynble
krynble approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks all right, had the same issue as Ricardo but the latest commit fixed it for me as well.

Also working fine with queue mode.

@netroy
Copy link
Member Author

netroy commented Apr 12, 2023

the failing e2e test is coming from master.

@netroy netroy merged commit 10f8c35 into master Apr 12, 2023
@netroy netroy deleted the N8N-5289-repository-classes branch April 12, 2023 08:59
MiloradFilipovic added a commit that referenced this pull request Apr 13, 2023
@MiloradFilipovic
Merge branch 'master' into feature/resource-mapping-component
8576dcc 
* master: (62 commits)
  fix(editor): Redirect to home page after saving data on SAML onboarding page (no-changelog) (#5961)
  feat: Replace Vue.extend with defineComponent in design system (no-changelog) (#5918)
  feat(MySQL Node): Overhaul
  fix(OpenAI Node): Update models to only show those supported (#5805)
  ci: Add test for wait node (no-changelog) (#5414)
  fix(Github Trigger Node): Remove content_reference event (#5830)
  ci: Validate load options methods in nodes-base (no-changelog) (#5862)
  ci: Use `--chown=node:node` in COPY commands in the custom docker image (no-changelog) (#5913)
  🚀 Release 0.224.0 (#5957)
  fix(NocoDB Node): Fix for updating or deleting rows with not default primary keys
  fix(HTTP Request Node): Show detailed error message in the UI again (#5959)
  ci: Prevent skipping of E2E fail job (no-changelog) (#5958)
  ci: Fix E2E tests on master (no-changelog) (#5960)
  refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) (#5953)
  fix(core): Validate customData keys and values (#5920) (no-changelog)
  feat(editor): Add user activation survey (#5677)
  fix(editor): Update vite legacy-plugin browser target (no-changelog) (#5952)
  docs: Fix typo in AWS S3 and S3 nodes for parent folder key (#5933)
  fix(core): Update xml2js to address CVE-2023-0842 (#5948)
  fix(Code Node): Update vm2 to address CVE-2023-29017 (#5947)
  ...

# Conflicts:
#	packages/workflow/src/Interfaces.ts
MiloradFilipovic added a commit that referenced this pull request Apr 13, 2023
@MiloradFilipovic
Merge branch 'feature/resource-mapping-component' into NODE-399-resou…
1d808a9 
…rce-mapper-ui

* feature/resource-mapping-component: (62 commits)
  fix(editor): Redirect to home page after saving data on SAML onboarding page (no-changelog) (#5961)
  feat: Replace Vue.extend with defineComponent in design system (no-changelog) (#5918)
  feat(MySQL Node): Overhaul
  fix(OpenAI Node): Update models to only show those supported (#5805)
  ci: Add test for wait node (no-changelog) (#5414)
  fix(Github Trigger Node): Remove content_reference event (#5830)
  ci: Validate load options methods in nodes-base (no-changelog) (#5862)
  ci: Use `--chown=node:node` in COPY commands in the custom docker image (no-changelog) (#5913)
  🚀 Release 0.224.0 (#5957)
  fix(NocoDB Node): Fix for updating or deleting rows with not default primary keys
  fix(HTTP Request Node): Show detailed error message in the UI again (#5959)
  ci: Prevent skipping of E2E fail job (no-changelog) (#5958)
  ci: Fix E2E tests on master (no-changelog) (#5960)
  refactor(core): Use injectable classes for db repositories (part-1) (no-changelog) (#5953)
  fix(core): Validate customData keys and values (#5920) (no-changelog)
  feat(editor): Add user activation survey (#5677)
  fix(editor): Update vite legacy-plugin browser target (no-changelog) (#5952)
  docs: Fix typo in AWS S3 and S3 nodes for parent folder key (#5933)
  fix(core): Update xml2js to address CVE-2023-0842 (#5948)
  fix(Code Node): Update vm2 to address CVE-2023-29017 (#5947)
  ...

# Conflicts:
#	packages/workflow/src/Interfaces.ts
@janober
Copy link
Member

janober commented Apr 19, 2023

Got released with [email protected]

sunilrr pushed a commit to fl-g6/qp-n8n that referenced this pull request Apr 24, 2023
@netroy @RicardoE105 @sunilrr
refactor(core): Use injectable classes for db repositories (part-1) (…
d8d6f66 
…no-changelog) (n8n-io#5953)

Co-authored-by: ricardo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netroy @RicardoE105 @janober @krynble