-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SERIAL_DEBUG
into RF24_DEBUG
#980
Comments
In researching why some portability uses RF24/utility/ATXMegaD3/RF24_arch_config.h Line 33 in 29231f2
I found a comment way back in 2016 that might be trying to reference this situation. 😄 |
Hehe, I think the RF24Network define should probably be changed to |
Yeah, we can do that too. It is just a simple search and replace solution. |
BTW, the debug toggle in RF24Mesh is |
Sure - Nice and consistent and very unlikely to be repeated in other code. |
RF24Ethernet seems to be already using some lib-specific debug toggle names. RF24Gateway seems to use a |
Yeah lol |
Basically, we need a way to differentiate between enabling RF24 debug output and enabling RF24Network debug output when compiling the RF24 stack into a single binary. This probably isn't a big concern, but the RF24 debug output can be noisy and make it difficult to see/find debug output from RF24Network.
Describe the solution you'd like
Just as the title says: Change
SERIAL_DEBUG
intoRF24_DEBUG
. We should also update the macro name fromIF_SERIAL_DEBUG()
intoIF_RF24_DEBUG()
. Doing this will avoid having to change the toggle/flags for the various levels of debug output in RF24Network.Describe alternatives you've considered
None
Additional context
See nRF24/pyRF24#64 (comment). While this problem was identified in the pyRF24 project, I think it would also affect any project that involves RF24 and RF24Network libs using debug output for the Arduino and PicoSDK platforms. This problem is not present in typical usage on Linux where the RF24 stack is compiled into separate binary drivers.
The text was updated successfully, but these errors were encountered: