Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recieved -> received typos #817

Merged
merged 1 commit into from
Dec 29, 2021
Merged

fix recieved -> received typos #817

merged 1 commit into from
Dec 29, 2021

Conversation

prawnpie
Copy link

I noticed this while reading the docs. Figured I'd submit a PR since it's on GitHub.

Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I often forget that "i before e except after c" rule unless I say it out load when I write. 😁 It would go a long way if vscode had some spell-checking for doc comments only.

@2bndy5 2bndy5 merged commit 0054260 into nRF24:master Dec 29, 2021
@2bndy5
Copy link
Member

2bndy5 commented Dec 29, 2021

These changes may not get shown in the stable release docs for a while. I'm currently trying out a different way to organize the growing list of functions.

Also, I've been working on making the doxygen HTML output material-design compatible, but I'm slowing finding out now how radically different the html generation has changed since doxygen v1.8.17 (been testing on v1.9.1)... In the end, I expect most of the HTML to get modified via JS (🤮) on-browser-load.

@prawnpie
Copy link
Author

Thanks for merging. No worries on timing until it's in the release docs, just happy to fix it upstream so it'll eventually be sorted. Now, off to find a reputable nrf24l01 module that actually works... so many crappy clones out there. I just ordered 2 from sparkfun just to have some reference modules that I can trust. sheesh.

@2bndy5
Copy link
Member

2bndy5 commented Dec 30, 2021

Power is the main problem with these modules. I think the sparkfun modules address this by integrating its own power regulator, but I have no experience with them. I recently received (yes I typed that wrong again at first) some ebyte modules that seem reliable, but those ebyte modules tend to have different power specs depending on which module model you purchase.

@2bndy5
Copy link
Member

2bndy5 commented Dec 30, 2021

It would go a long way if vscode had some spell-checking for doc comments only.

I just found this extension which seems useful

@2bndy5 2bndy5 mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants