Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update py examples #851

Merged
merged 10 commits into from
Jul 9, 2022
Merged

Update py examples #851

merged 10 commits into from
Jul 9, 2022

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jul 9, 2022

These are improvements to the python examples that I found useful when testing nRF24/pyRF24#9

I also added the scanner example from #714 (comment)

These changes may not be python 2 compatible. Not really sure if that's a problem because RPi OS no longer ships with python2. I'm more concerned with people that haven't updated their RPi's OS image in over a year.

@TMRh20 TMRh20 merged commit 8ddd1e8 into master Jul 9, 2022
@2bndy5
Copy link
Member Author

2bndy5 commented Jul 9, 2022

I think if I revert the use of f-strings (f"text {data_var}"), then it should remain python2 compatible. TBH, I never actually used python2 for anything (at least not voluntarily - the chocolate pckage manager used to use python2).

oh, it was merged while writing this. 😆 . I can still revert the f-strings if becomes a problem later.

@2bndy5 2bndy5 deleted the update-py-examples branch July 9, 2022 12:10
@2bndy5
Copy link
Member Author

2bndy5 commented Jul 9, 2022

First order of business (later after I hopefully get some sleep), is the release crusade 🎠 .

@TMRh20
Copy link
Member

TMRh20 commented Jul 9, 2022 via email

@2bndy5
Copy link
Member Author

2bndy5 commented Jul 9, 2022

Its like every other day - and I hate taken sleeping meds.

@2bndy5
Copy link
Member Author

2bndy5 commented Jul 9, 2022

holy crap! this new button is going to make my life super easy: image

@2bndy5
Copy link
Member Author

2bndy5 commented Jul 9, 2022

ok the auto-generate relaese notes button isn't perfect

🤣

Still, that release crusade was painless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants