-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promiscuous scanners #955
Promiscuous scanners #955
Conversation
Finished testing the new scannerGraphic Arduino example on both the I2C and SPI displays that I have lying around (product links in OP). FYI, the ST7789 seems to be slightly faster. I think the only thing left to review is to make sure the code is consistent for assessing the noise detection; specifically
|
7ac0537
to
3fa016d
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
f1f49bc
to
fcad232
Compare
76eee8d
to
3fda357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was obviously a pile of work!
I tested what I can, but don't have any displays to test the graphic example and wasn't able to test the pico example.
I tested the scanner graphic pretty well. I'm happy with it as is. There might be contributors in the future to improve it further, but for now I just wanted it be a simple scanner display. There's little usability in that example because it can't tell you which exact channels were detecting noise; there just isn't enough room on those small displays to show active channels' number. It would make for a neat idea in a cosplay Star Trek TNG tricorder device... 🤓 I did test all other examples' modifications too. |
similar to changes in nRF24/RF24#955
similar to changes in nRF24/RF24#955
Satisfies #852 and resolves #714
I've been re-basing this branch for almost 2 years. With the fix from #952 (& #954), I'm finally ready to get these scanner updates into master.
New Examples
SPI_DISPLAY
in codeI2C_DISPLAY
in codelibncurses5-dev
installed. Only builds with CMake.Modified Examples