Use hasmap to find comment data #374

[nook24]

This is my attempt to patch #374. Would be good if you could review this.
Signed-off-by: nook24 [email protected]

[sni]

Now there is a comment_hashtable and a comment_hashlist. Have you checked if we need both by any chance?

[nook24]

Tbh, I'm not sure if I understand whats happening with comment_hashlist by 100%. It is only used by comment *get_next_comment_by_host(char *host_name, comment *start). I think it is possible to get rid of it but I tried to touched as less code as possible.

How ever, by removing comment_hashlist we could also delete this:

naemon-core/src/naemon/shared.c

Lines 416 to 437 in 4700219

	/**************************************************
	*************** HASH FUNCTIONS *******************
	**************************************************/
	/* dual hash function */
	int hashfunc(const char *name1, const char *name2, int hashslots)
	{
	unsigned int i, result;
	result = 0;
	if (name1)
	for (i = 0; i < strlen(name1); i++)
	result += name1[i];
	if (name2)
	for (i = 0; i < strlen(name2); i++)
	result += name2[i];
	result = result % hashslots;
	return result;
	}

[sni]

looks good

[sni]

could you please rebase this PR on the latest HEAD. This should also trigger the checks again.

[sni]

i just rebased this and had another look. It wont't work like this because the comment_list has only next pointer but no prev. So there is no way to remove something in the middle without walking along all the comment_list again.
I guess best would be to add a prev pointer to the comment struct as well, even though this means all NEB modules have to be rebuild again.

[sni]

i made some changes and created #420