Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid removing pub from members named type #40

Merged
merged 1 commit into from
May 25, 2022

Conversation

cwfitzgerald
Copy link
Contributor

Closes #39

Not sure if there's anything else I need to do to make the regeneration happen right.

@nagisa
Copy link
Owner

nagisa commented May 25, 2022

You can either regenerate it yourself by running make_sys.sh or it'll get regenerated by the CI in a couple hours after this lands. I'll be looking at merging this PR in an hour or so.

@cwfitzgerald
Copy link
Contributor Author

Alright, I'll just wait for CI to regen then, thanks!

@nagisa nagisa merged commit 80a9c08 into nagisa:main May 25, 2022
@nagisa
Copy link
Owner

nagisa commented May 25, 2022

Merged, thanks!

@Imberflur
Copy link
Contributor

's/pub type /type/g'
                ^

this probably needs a space here to avoid removing the space

@nagisa
Copy link
Owner

nagisa commented May 25, 2022

Yeah, I have added that in a follow-up here.

@Ralith
Copy link
Contributor

Ralith commented May 26, 2022

A more general/robust solution than sed might be to pass allowlist regexps to bindgen.

@nagisa
Copy link
Owner

nagisa commented May 26, 2022

I remember trying to do that back when the generator was initially added. I don't remember exactly why it didn't work but it must have been either one of:

  1. It doesn't work for system header stuff that the API depends on and bindgen still publicly exports the types;
  2. Bindings no longer compile due to missing type definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__tracy_gpu_new_context_data has private field making it unconstructable
4 participants