Introduce client_extra_certs option to SSLConfig #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nahi I believe that a testcase should be added to this to |
Some websites relying on client certificate authentication reject requests with proper client certificate unless authority chain is presented with the certificate as well. New `client_extra_certs` tunable allows adding CA certificates to the `extra_chain_cert` option of SSL connection context, thus providing a way of supplying the authority chain together with request.
timon
force-pushed
the
feature/ssl-extra-certs
branch
from
d9e59fb
to
d32f056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some websites that rely on client certificate authentication reject requests with proper client certificate unless authority chain is presented with the certificate as well.
This PR introduces a new SSLConfig option,
client_extra_certs, that allows supplying CA certificatesalong with a request.