Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed line endings to LF in command line tool causing error on mac os #4

Closed
wants to merge 1 commit into from

Conversation

jklimke
Copy link

@jklimke jklimke commented Jul 10, 2018

Hi,

i noticed a problem with the command line tool that appears in MacOS environments.

I executed the following command in my node project root directory

./node_modules/.bin/gltf-import-export
env: node\r: No such file or directory

After opening the file in VSCode and converting the line ending to LF instead or CRLF the converter works fine.

Could you please try to fix the line endings within the tool file.

It seems to be a problem that is know also in npm and it seems that there is no better solution thanusing LF line endings for programming.

see: npm/npm#12371
and nodejs/node#11478 recommends

To resolve this, please either hand-write the first line in the script, or work with the project which created the script file and the shebang line to address this.

I did this in this pull request.

@najadojo
Copy link
Owner

@jklimke your changes didn't resolve the issue but I did make some configuration changes and published a new version to npm with the fixes. Thanks for bringing this to my attention.

@najadojo najadojo closed this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants