name_update Qt GUI

[JeremyRand]

This PR adds the name_update GUI.

[JeremyRand]

@randy-waterhouse You may be interested in reviewing this.

[JeremyRand]

Updated PR to use Optional in a few places where it makes sense. Will squash after review (prior to a merge).

[JeremyRand]

@domob1812 This PR is ready for review.

[JeremyRand]

@domob1812 Any chance you could review this?

[domob1812]

Sorry for the long delay and thanks for this PR! Looks good (with the usual caveat that I'm not really a Qt expert so could only review those parts lightly), I've just marked some tiny nits.

[JeremyRand]

@domob1812 Addressed feedback (and also fixed some minor formatting issues in configurenamedialog.ui, most notably a bug that broke the hyperlink coloring in Dark Mode). Let me know if this is good, and I'll squash before you merge it.

[domob1812]

ACK d0bb93d. Please squash the commits, then I'll merge the PR.

[JeremyRand]

One more quick fix before we merge this; the latest commit prevents the name from being displayed as HTML in the Configure dialog. This is probably not easy for an attacker to exploit (they'd need to send you a name, and get you to try to update it, and then they'd have to hope that you don't notice that the Manage Names list shows the name differently from the Configure dialog), but still a good idea to fix.

@domob1812 Let me know if this final commit is okay, then I'll squash everything.

[domob1812]

One more quick fix before we merge this; the latest commit prevents the name from being displayed as HTML in the Configure dialog. This is probably not easy for an attacker to exploit (they'd need to send you a name, and get you to try to update it, and then they'd have to hope that you don't notice that the Manage Names list shows the name differently from the Configure dialog), but still a good idea to fix.

@domob1812 Let me know if this final commit is okay, then I'll squash everything.

Yes, that is ok of course.

[JeremyRand]

@domob1812 Squashed. Left the registerName commit separate since it's atomic to the main commit.

[domob1812]

For the record, this broke the build for me:

In file included from qt/configurenamedialog.cpp:1:
./qt/configurenamedialog.h:4:10: fatal error: optional.h: No such file or directory
 #include <optional.h>
          ^~~~~~~~~~~~

I guess that's trivial to fix, will do now. @JeremyRand did it build for you (I assume so)?

I believe upstream Bitcoin recently removed their custom Optional, switching to C++17's std::optional.

[domob1812]

Fixed in 67a184a.

[JeremyRand]

For the record, this broke the build for me:

In file included from qt/configurenamedialog.cpp:1:
./qt/configurenamedialog.h:4:10: fatal error: optional.h: No such file or directory
 #include <optional.h>
          ^~~~~~~~~~~~

I guess that's trivial to fix, will do now. @JeremyRand did it build for you (I assume so)?

I believe upstream Bitcoin recently removed their custom Optional, switching to C++17's std::optional.

@domob1812 It did build for me, but I hadn't rebased for a couple of months. Usually this is a good thing since frequent rebasing makes review more difficult, and typically any issues caused by not rebasing will be caught by Cirrus. Alas, Cirrus is routinely failing on master for other reasons, which I guess caused us to miss this one. I suppose this is a good reason to repair the other failures.