correct makefile #220
Open
correct makefile #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most coins have a makefile.unix, Namecoin does not, Do not recycle the build docs without documenting the wierd changes you make!
|
Thanks for doing this! Hopefully a Namecoin dev comes along soon to take a look at this. That file as a whole is quite incorrect. For one, Qt is the framework being used instead of wxWidgets. Focusing specifically on the part you corrected, there are still some issues or possible optimizations (make expects the makefile to be named Makefile by default, so you don't need to specify the name in that case). I have made some more fixes. I suggest you update your pull request with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most coins have a makefile.unix, Namecoin does not, Do not recycle the build docs without documenting the wierd changes you make!