Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more golangci-lint linters on Cirrus #97

Open
JeremyRand opened this issue Aug 10, 2022 · 0 comments
Open

Enable more golangci-lint linters on Cirrus #97

JeremyRand opened this issue Aug 10, 2022 · 0 comments
Labels
enhancement New feature or request Hacktoberfest tests

Comments

@JeremyRand
Copy link
Member

JeremyRand commented Aug 10, 2022 •
edited
Loading

Currently, some Go linters are marked as non-mandatory, because we'd like to pass them but we don't right now. It would be desirable to fix whatever failures they trigger, and then enable them as mandatory.
@JeremyRand JeremyRand added enhancement New feature or request Hacktoberfest labels Aug 10, 2022
@JeremyRand JeremyRand mentioned this issue Aug 10, 2022
Merged
JeremyRand pushed a commit that referenced this issue Aug 10, 2022
Merge #102: Cirrus: Mark gocritic linter as mandatory
dc1554d 
f6e8748 Cirrus: Mark gocritic linter as mandatory (Jeremy Rand)
f00c922 p11mod / GetMechanismList: Call slot.Mechanisms() (Jeremy Rand)
5401d6b fromTemplate: rewrite if-else chain to switch (Jeremy Rand)
9a709fa toTemplate: space between // and comment text (Jeremy Rand)

Pull request description:

  Refs #97

Top commit has no ACKs.

Tree-SHA512: 7e82e450546fee84c5e2db86a47edc49fcac1a7abb9611175a6f0fc83289f4448a5a5d149327b6453b343a0e1501abcfdce00a9559230a76a7e67d87a8f60736
JeremyRand pushed a commit to JeremyRand/pkcs11mod that referenced this issue Aug 11, 2022
Cirrus: Mark more linters as mandatory
b9d7f60 
Refs namecoin#97
JeremyRand pushed a commit to JeremyRand/pkcs11mod that referenced this issue Aug 11, 2022
Cirrus: Mark more linters as mandatory
fffb974 
Refs namecoin#97
JeremyRand pushed a commit to JeremyRand/pkcs11mod that referenced this issue Aug 12, 2022
Cirrus: Mark more linters as mandatory
761221d 
Refs namecoin#97
JeremyRand pushed a commit to JeremyRand/pkcs11mod that referenced this issue Aug 12, 2022
Cirrus: Mark more linters as mandatory
6f189e3 
Refs namecoin#97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand