Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add typescript definition support for node (node-ts) with protoc-gen-ts plugin #111

Closed
H3JFC opened this issue Feb 21, 2019 · 5 comments

Comments

@H3JFC
Copy link

H3JFC commented Feb 21, 2019

It would be nice to add typescript support for node via the protoc-gen-ts plugin.

I'm happy to take this on as a PR.

Potential Changes to Dockerfile

RUN set -ex && apk --update --no-cache add \
 ...
    nodejs \
    nodejs-npm \
    && npm i -g ts-protoc-gen

ENV PROTOC_GEN_TS_PATH /usr/local/lib/node_modules/protoc-gen-ts

Potential Changes to all/Entrypoint.sh

case $GEN_LANG in
...
"node(-ts)*") ...
...
esac
....
if [[ $GEN_LANG == "node-ts" ]]; then
    protoc \
        --plugin="protoc-gen-ts=${PROTOC_GEN_TS_PATH}" \
        --ts_out=$OUT_DIR \
        ${PROTO_FILES[@]}
fi
@damiannolan
Copy link

This would be awesome!

@esilkensen
Copy link
Contributor

esilkensen commented May 14, 2019

I'd like to see this too 👍

Are you referring to ts-protoc-gen (rather than protoc-gen-ts)? Edit: never mind, sorry, I see that package flips the name just as you listed it.

@mhamrah
Copy link
Contributor

mhamrah commented May 14, 2019

PR's welcome!

@esilkensen
Copy link
Contributor

Sounds good, I will give this a shot and hope to open a PR!

@mhamrah
Copy link
Contributor

mhamrah commented Jun 5, 2019

Believe we can close this now that's to #125 !

@mhamrah mhamrah closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants