Add TypeScript declaration support using protoc-gen-ts plugin #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esilkensen
commented
May 15, 2019
esilkensen
force-pushed
the
feature/node-ts-support
branch
from
6e54d86
to
254a604
Compare
esilkensen
commented
May 15, 2019
esilkensen
force-pushed
the
feature/node-ts-support
branch
from
254a604
to
84ef1b8
Compare
esilkensen
commented
May 15, 2019
esilkensen
force-pushed
the
feature/node-ts-support
branch
from
84ef1b8
to
4cdba1d
Compare
mhamrah
approved these changes
May 31, 2019
|
Thanks sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation of the feature request described in #111:
My proposal is to add a
--with-typescriptoption to thenodelanguage that leverages the ts-protoc-gen plugin to generate TypeScript declaration files (.d.tsfiles) that match the JavaScript output ofprotoc --js_out=import_style=commonjs,binary.That plugin can also generate service definitions that include TypeScript declarations in the structure required by the Improbable grpc-web implementation. This PR doesn't use that feature; I thought if it would be useful to expose it as an option, maybe it would make sense as an option to the
weblanguage, and could be its own PR?