Add mypy support #288
Merged
Add mypy support #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ido-namely ! 👋 |
maxjakob
commented
Mar 4, 2022
maxjakob
force-pushed
the
mj-mypy-support
branch
from
a7eee59
to
378ab83
Compare
ido-namely
reviewed
Sep 2, 2022
There was a problem hiding this comment.
Thank you @maxjakob for the contribution!
I left a few comments but the PR looks really good!
I also suggest to add tests in https://github.com/namely/docker-protoc/blob/master/all/test/all_test.go, should be straightforward.
Might be better if I let the build run after that.
Thanks!
maxjakob
commented
Sep 2, 2022
There was a problem hiding this comment.
Thanks so much for the feedback @ido-namely! I addressed most of your comments.
maxjakob
requested review from
ido-namely
and removed request for
ido-namely
Co-authored-by: Ido David <[email protected]>
jcburley
approved these changes
Sep 2, 2022
maxjakob
requested review from
ido-namely
and removed request for
abe545 and
nycdotnet
ido-namely
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
protoc-gen-mypyplugin through https://github.com/nipunn1313/mypy-protobuf.Addresses #81.