Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Renovate configuration #314

Merged
merged 33 commits into from
Jul 19, 2022
Merged

Enhance Renovate configuration #314

merged 33 commits into from
Jul 19, 2022

Conversation

ido-namely
Copy link
Contributor

@ido-namely ido-namely commented Jul 10, 2022

  • Manage more dependencies with Renovate
  • Group gateway go package separately (we avoid upgrading this package atm because of a breaking change regarding fieldmasks)
  • Manage gateway go.mod template using Renovate's Go data source
  • Remove go.sum.template (no need for it since the go app is vendored anew in the generated docker file).

Copy link
Contributor

@nycdotnet nycdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please make a small update to the readme discussing what Renovate is and how this project uses it? There is a link to it in the readme already but a few sentences to guide someone like me who may be interested to use the tooling you've set up but isn't quite sure where to get started (some typical commands for example) would be very helpful.

@ido-namely
Copy link
Contributor Author

Would you please make a small update to the readme discussing what Renovate is and how this project uses it? There is a link to it in the readme already but a few sentences to guide someone like me who may be interested to use the tooling you've set up but isn't quite sure where to get started (some typical commands for example) would be very helpful.

good call, will do.

Copy link
Contributor

@nycdotnet nycdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ido-namely !

.github/README.md Outdated Show resolved Hide resolved
.github/README.md Outdated Show resolved Hide resolved
ido-namely and others added 2 commits July 11, 2022 18:02
Co-authored-by: Steve Ognibene <[email protected]>
Co-authored-by: Steve Ognibene <[email protected]>
Copy link
Collaborator

@jcburley jcburley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this LGTM, and the Renovate explanation helps give me some context, but I'm not yet enough of an expert to properly review all of this, so will (for now) just Comment.

Please let me know whether you want me to find some time to take a deeper dive in order to reach a go/no-go decision on this.

(Overall this seems like another great improvement to me.)

.github/README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ido-namely ido-namely merged commit ddcb1d2 into namely:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants