-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Renovate configuration #314
Conversation
ido-namely
commented
Jul 10, 2022
•
edited
Loading
edited
- Manage more dependencies with Renovate
- Group gateway go package separately (we avoid upgrading this package atm because of a breaking change regarding fieldmasks)
- Manage gateway go.mod template using Renovate's Go data source
- Remove go.sum.template (no need for it since the go app is vendored anew in the generated docker file).
chore(deps): update dependency google.golang.org/grpc to v1.47.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please make a small update to the readme discussing what Renovate is and how this project uses it? There is a link to it in the readme already but a few sentences to guide someone like me who may be interested to use the tooling you've set up but isn't quite sure where to get started (some typical commands for example) would be very helpful.
good call, will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ido-namely !
Co-authored-by: Steve Ognibene <[email protected]>
Co-authored-by: Steve Ognibene <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this LGTM, and the Renovate explanation helps give me some context, but I'm not yet enough of an expert to properly review all of this, so will (for now) just Comment.
Please let me know whether you want me to find some time to take a deeper dive in order to reach a go/no-go decision on this.
(Overall this seems like another great improvement to me.)