reviewdog exited with status code: 1

The job was canceled because "libcoap-rs" failed.

The operation was canceled.

Process completed with exit code 101.

Process completed with exit code 101.

Process completed with exit code 101.

Process completed with exit code 101.

warning: struct `PkiContextBuilder` is never constructed --> libcoap/src/crypto/pki_rpk.rs:9:12 | 9 | pub struct PkiContextBuilder {} | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: struct `PkiContext` is never constructed --> libcoap/src/crypto/pki_rpk.rs:11:12 | 11 | pub struct PkiContext { | ^^^^^^^^^^

warning: enum `PkiKey` is never used --> libcoap/src/crypto/pki_rpk.rs:17:10 | 17 | pub enum PkiKey { | ^^^^^^

warning: associated items `from_raw_dtls_key_t` and `into_raw_dtls_key_t` are never used --> libcoap/src/crypto/pki_rpk.rs:27:26 | 26 | impl PkiKey { | ----------- associated items in this implementation 27 | pub(crate) unsafe fn from_raw_dtls_key_t(dtls_key: coap_dtls_key_t) -> Self { | ^^^^^^^^^^^^^^^^^^^ ... 42 | pub(crate) fn into_raw_dtls_key_t(self) -> coap_dtls_key_t { | ^^^^^^^^^^^^^^^^^^^

warning: struct `PemFileKey` is never constructed --> libcoap/src/crypto/pki_rpk.rs:60:12 | 60 | pub struct PemFileKey { | ^^^^^^^^^^

warning: associated items `new`, `new_with_paths`, `from_raw_pki_key_pem`, and `into_raw_pki_key_pem` are never used --> libcoap/src/crypto/pki_rpk.rs:67:12 | 66 | impl PemFileKey { | --------------- associated items in this implementation 67 | pub fn new(ca_file: Option<CString>, public_cert: CString, private_key: CString) -> Self { | ^^^ ... 76 | pub fn new_with_paths( | ^^^^^^^^^^^^^^ ... 90 | pub(crate) unsafe fn from_raw_pki_key_pem(pki_key_pem: coap_pki_key_pem_t) -> Self { | ^^^^^^^^^^^^^^^^^^^^ ... 101 | pub(crate) fn into_raw_pki_key_pem(self) -> coap_pki_key_pem_t { | ^^^^^^^^^^^^^^^^^^^^

warning: struct `PemMemoryKey` is never constructed --> libcoap/src/crypto/pki_rpk.rs:110:12 | 110 | pub struct PemMemoryKey { | ^^^^^^^^^^^^

warning: associated items `new`, `from_raw_pki_key_pem_buf`, and `into_raw_pki_key_pem_buf` are never used --> libcoap/src/crypto/pki_rpk.rs:117:12 | 116 | impl PemMemoryKey { | ----------------- associated items in this implementation 117 | pub fn new( | ^^^ ... 129 | pub(crate) unsafe fn from_raw_pki_key_pem_buf(pki_key_pem: coap_pki_key_pem_buf_t) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^ ... 147 | pub(crate) fn into_raw_pki_key_pem_buf(self) -> coap_pki_key_pem_buf_t { | ^^^^^^^^^^^^^^^^^^^^^^^^

warning: trait `PkiCnValidator` is never used --> libcoap/src/crypto/pki_rpk.rs:165:11 | 165 | pub trait PkiCnValidator {} | ^^^^^^^^^^^^^^

warning: trait `PkiSniKeyProvider` is never used --> libcoap/src/crypto/pki_rpk.rs:167:11 | 167 | pub trait PkiSniKeyProvider {} | ^^^^^^^^^^^^^^^^^

warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..` --> libcoap/src/crypto/psk/client.rs:46:37 | 46 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if ec_jpake { 1 } else { 0 }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else = note: `#[warn(clippy::obfuscated_if_else)]` on by default

warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..` --> libcoap/src/crypto/psk/client.rs:52:36 | 52 | self.ctx.raw_cfg.use_cid = use_cid.then_some(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if use_cid { 1 } else { 0 }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else

warning: this lifetime isn't used in the impl --> libcoap/src/crypto/psk/client.rs:213:6 | 213 | impl<'a, T: Debug> ClientPskHintKeyProvider for T | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

warning: use of `.then_some(..).unwrap_or(..)` can be written more clearly with `if .. else ..` --> libcoap/src/crypto/psk/server.rs:46:37 | 46 | self.ctx.raw_cfg.ec_jpake = ec_jpake.then_some(1).unwrap_or(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if ec_jpake { 1 } else { 0 }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else

warning: this call to `as_ref` does nothing --> libcoap/src/crypto/psk/server.rs:248:20 | 248 | let keys = self.as_ref(); | ^^^^^^^^^^^^^ help: try: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref = note: `#[warn(clippy::useless_asref)]` on by default

warning: casting the result of `from_raw_parts_mut` to *mut [u8] --> libcoap/src/crypto/psk/mod.rs:115:43 | 115 | let data = unsafe { Box::from_raw(std::slice::from_raw_parts_mut(key.s as *mut u8, key.length) as *mut [u8]) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `core::ptr::slice_from_raw_parts_mut(key.s as *mut u8, key.length)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_slice_from_raw_parts = note: `#[warn(clippy::cast_slice_from_raw_parts)]` on by default

warning: useless conversion to the same type: `std::boxed::Box<[u8]>` --> libcoap/src/crypto/psk/mod.rs:124:19 | 124 | data: value.into(), | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: using `libc::strlen` on a `CString` or `CStr` value --> libcoap/src/types.rs:761:17 | 761 | libc::strlen(uri.uri_str.0.as_ptr()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `uri.uri_str.0.as_bytes().len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#strlen_on_c_strings = note: `#[warn(clippy::strlen_on_c_strings)]` on by default

The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@main. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/