Skip to content

(WIP) Rework of DTLS code, add DTLS PKI/RPK #157

(WIP) Rework of DTLS code, add DTLS PKI/RPK

(WIP) Rework of DTLS code, add DTLS PKI/RPK #157

GitHub Actions / clippy (libcoap-rs) completed Sep 5, 2024 in 1s

reviewdog [clippy (libcoap-rs)] report

reported by reviewdog 🐶

Findings (3)

libcoap/src/context.rs|27 col 20| error[E0432]: unresolved import crate::crypto::pki_rpk
--> libcoap/src/context.rs:27:20
|
27 | use crate::crypto::pki_rpk::PkiContext;
| ^^^^^^^ could not find pki_rpk in crypto
|
note: found an item that was configured out
--> libcoap/src/crypto/mod.rs:13:9
|
13 | pub mod pki_rpk;
| ^^^^^^^
note: the item is gated behind the dtls-pki feature
--> libcoap/src/crypto/mod.rs:12:7
|
12 | #[cfg(feature = "dtls-pki")]
| ^^^^^^^^^^^^^^^^^^^^
libcoap/src/crypto/psk/mod.rs|9 col 5| warning: unused import: std::fmt::Debug
--> libcoap/src/crypto/psk/mod.rs:9:5
|
9 | use std::fmt::Debug;
| ^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
libcoap/src/session/client.rs|117 col 34| error[E0599]: no variant or associated item named Pki found for enum crypto::ClientCryptoContext in the current scope
--> libcoap/src/session/client.rs:117:34
|
117 | ClientCryptoContext::Pki(pki_ctx) => {
| ^^^ variant or associated item not found in ClientCryptoContext
|
::: libcoap/src/crypto/mod.rs:20:1
|
20 | pub enum ClientCryptoContext {
| ---------------------------- variant or associated item Pki not found for this enum

Filtered Findings (2)

libcoap/src/types.rs|379 col 86| warning: can be more succinctly written as a byte str
--> libcoap/src/types.rs:379:86
|
379 | Self::construct_uri_string_from_parts(scheme, host, port, path.unwrap_or(&[b'/']), query.unwrap_or(&[]))?;
| ^^^^^^^ help: try: b"/"
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices
= note: #[warn(clippy::byte_char_slices)] on by default
libcoap/src/types.rs|419 col 86| warning: can be more succinctly written as a byte str
--> libcoap/src/types.rs:419:86
|
419 | Self::construct_uri_string_from_parts(scheme, host, port, path.unwrap_or(&[b'/']), query.unwrap_or(&[]))?;
| ^^^^^^^ help: try: b"/"
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices

Annotations

Check failure on line 27 in libcoap/src/context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy (libcoap-rs)

[clippy (libcoap-rs)] libcoap/src/context.rs#L27

error[E0432]: unresolved import `crate::crypto::pki_rpk`
  --> libcoap/src/context.rs:27:20
   |
27 | use crate::crypto::pki_rpk::PkiContext;
   |                    ^^^^^^^ could not find `pki_rpk` in `crypto`
   |
note: found an item that was configured out
  --> libcoap/src/crypto/mod.rs:13:9
   |
13 | pub mod pki_rpk;
   |         ^^^^^^^
note: the item is gated behind the `dtls-pki` feature
  --> libcoap/src/crypto/mod.rs:12:7
   |
12 | #[cfg(feature = "dtls-pki")]
   |       ^^^^^^^^^^^^^^^^^^^^
Raw output
libcoap/src/context.rs:27:20:e:error[E0432]: unresolved import `crate::crypto::pki_rpk`
  --> libcoap/src/context.rs:27:20
   |
27 | use crate::crypto::pki_rpk::PkiContext;
   |                    ^^^^^^^ could not find `pki_rpk` in `crypto`
   |
note: found an item that was configured out
  --> libcoap/src/crypto/mod.rs:13:9
   |
13 | pub mod pki_rpk;
   |         ^^^^^^^
note: the item is gated behind the `dtls-pki` feature
  --> libcoap/src/crypto/mod.rs:12:7
   |
12 | #[cfg(feature = "dtls-pki")]
   |       ^^^^^^^^^^^^^^^^^^^^


__END__

Check warning on line 9 in libcoap/src/crypto/psk/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy (libcoap-rs)

[clippy (libcoap-rs)] libcoap/src/crypto/psk/mod.rs#L9

warning: unused import: `std::fmt::Debug`
 --> libcoap/src/crypto/psk/mod.rs:9:5
  |
9 | use std::fmt::Debug;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
Raw output
libcoap/src/crypto/psk/mod.rs:9:5:w:warning: unused import: `std::fmt::Debug`
 --> libcoap/src/crypto/psk/mod.rs:9:5
  |
9 | use std::fmt::Debug;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default


__END__

Check failure on line 117 in libcoap/src/session/client.rs

See this annotation in the file changed.

@github-actions github-actions / clippy (libcoap-rs)

[clippy (libcoap-rs)] libcoap/src/session/client.rs#L117

error[E0599]: no variant or associated item named `Pki` found for enum `crypto::ClientCryptoContext` in the current scope
   --> libcoap/src/session/client.rs:117:34
    |
117 |             ClientCryptoContext::Pki(pki_ctx) => {
    |                                  ^^^ variant or associated item not found in `ClientCryptoContext`
    |
   ::: libcoap/src/crypto/mod.rs:20:1
    |
20  | pub enum ClientCryptoContext {
    | ---------------------------- variant or associated item `Pki` not found for this enum
Raw output
libcoap/src/session/client.rs:117:34:e:error[E0599]: no variant or associated item named `Pki` found for enum `crypto::ClientCryptoContext` in the current scope
   --> libcoap/src/session/client.rs:117:34
    |
117 |             ClientCryptoContext::Pki(pki_ctx) => {
    |                                  ^^^ variant or associated item not found in `ClientCryptoContext`
    |
   ::: libcoap/src/crypto/mod.rs:20:1
    |
20  | pub enum ClientCryptoContext {
    | ---------------------------- variant or associated item `Pki` not found for this enum


__END__