Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should serialize undefined #2

Open
NodeGuy opened this issue Sep 1, 2012 · 5 comments
Open

should serialize undefined #2

NodeGuy opened this issue Sep 1, 2012 · 5 comments

Comments

@NodeGuy
Copy link

NodeGuy commented Sep 1, 2012

If you add undefined to the list of primitives, the "should serialize primitives" test fails:

it("should serialize primitives", function() {
  var inputs = [undefined, 3, "foo", ["a", 3, "bar"]]
@nanodeath
Copy link
Owner

Thanks BallBearing, should be fixed in above commit.

@skeeto
Copy link

skeeto commented Mar 12, 2013

There still appears to be problems with this.

var hydrate = new Hydrate();
hydrate.parse(hydrate.stringify([undefined])); // => ["__hydrate_undef"]

@nanodeath nanodeath reopened this Mar 16, 2013
@nanodeath
Copy link
Owner

Hi @skeeto -- can you double-check? I'm running those exact commands and I'm getting [undefined] as expected.

@skeeto
Copy link

skeeto commented Mar 16, 2013

Using the pre-compiled version hosted here:

http://blog.maxaller.name/hydrate/gen/Hydrate.js (sha1sum: 6009764ff0659af87a44b1d4ecbb0d708a4c73df)

I'm still getting ["__hydrate_undef"] with both Firefox and Chrome.

@nanodeath
Copy link
Owner

Ah. Yes, that probably hasn't been updated -- it doesn't happen automatically. I'm making some more changes today, but I'll update it after that. I'm making some changes that will make it easier to compile it yourself, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants