Fixed bug where hydrate was not cleaning up special properties when in an array #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere inside an array
| @@ -253,15 +257,18 @@ scope = this | |||
| for num in [o.version..migrations.length - 1] | |||
| migrations[num].call(o) | |||
| delete o.version | |||
|
|
|||
| #do actual clean | |||
There was a problem hiding this comment.
Not sure what space you are referring to. You mean line break?
There was a problem hiding this comment.
It's just a nitpick, but your other comments have a space after the #, but this one doesn't ;)
|
Made few changes you mentioned |
nanodeath
added a commit
that referenced
this pull request
Apr 28, 2013
Fixed bug where hydrate was not cleaning up special properties when in an array
|
Thanks @freethenation, appreciate the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where hydrate was not cleaning up special properties when in an array. Run the new test case on the old code for a demonstration of the issue.