Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default fitter in pintk should be determined using Fitter.auto() #1665

Closed
abhisrkckl opened this issue Oct 27, 2023 · 5 comments · Fixed by #1663
Closed

Default fitter in pintk should be determined using Fitter.auto() #1665

abhisrkckl opened this issue Oct 27, 2023 · 5 comments · Fixed by #1663

Comments

@abhisrkckl
Copy link
Contributor

abhisrkckl commented Oct 27, 2023

Right now it is always GLSFitter.

@dlakaplan
Copy link
Contributor

No, not true. It uses the same logic (but implemented separately) to select the fitter.
e.g.,

pintk tests/datafile/NGC6440E.par tests/datafile/NGC6440E.tim -v 
...
INFO     (pint.pintk.pulsar             ): Since wideband=False and correlated=False, selecting fitter=WLSFitter

@dlakaplan
Copy link
Contributor

@abhisrkckl
Copy link
Contributor Author

I don't think it is the same logic. Fitter.auto() will choose DownhillWLSFitter instead of WLSFitter in this case.

(The always-GLSFitter thing was a mistake.)

@dlakaplan
Copy link
Contributor

--downhill will choose the downhill variant. if needed that can be made the default.

@abhisrkckl
Copy link
Contributor Author

--downhill will choose the downhill variant. if needed that can be made the default.

That's a better option, IMO, since the downhill fitters are supposed to be more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants