-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled axes for pintk when not in timing model or data #1663
Conversation
I think this should also be disabled when infinite-frequency TOAs are present. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
- Coverage 68.50% 68.46% -0.05%
==========================================
Files 104 104
Lines 24276 24287 +11
Branches 4333 4336 +3
==========================================
- Hits 16631 16628 -3
- Misses 6560 6573 +13
- Partials 1085 1086 +1
☔ View full report in Codecov by Sentry. |
Done. also fixed a bug regarding initial log level |
Can you also change the |
I did that. Not sure it's better (it requires a local import to avoid circular import errors). |
I had to undo those changes because of various failures |
This looks good to me. Shall I merge this? |
I think so |
pintk
fitters to downhill versions (Default fitter inpintk
should be determined usingFitter.auto()
#1665)is_binary
property to rely on class inheritance rather than component nameExample on a barycentered dataset (so no Astrometry or Binary component and all event data):