Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no clock files better #1309

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Conversation

aarchiba
Copy link
Contributor

Current master emits loud and unhelpful error messages when working with telescopes for which no clock file is needed. This PR fixes that and checks that these telescopes behave better.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1309 (aaf3771) into master (a74b41d) will increase coverage by 0.03%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   61.61%   61.64%   +0.03%     
==========================================
  Files          89       89              
  Lines       20165    20173       +8     
  Branches     3611     3614       +3     
==========================================
+ Hits        12424    12436      +12     
+ Misses       6966     6960       -6     
- Partials      775      777       +2     
Impacted Files Coverage Δ
src/pint/observatory/__init__.py 56.66% <0.00%> (+3.75%) ⬆️
src/pint/observatory/observatories.py 100.00% <ø> (ø)
src/pint/observatory/topo_obs.py 76.75% <40.00%> (-2.92%) ⬇️
src/pint/observatory/clock_file.py 80.38% <57.14%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74b41d...aaf3771. Read the comment docs.

@aarchiba
Copy link
Contributor Author

Improved messages: https://nanograv-pint--1309.org.readthedocs.build/en/1309/examples/check_clock_corrections.html

The ERFA messages are because Parkes has a clock correction at MJD 0.something. We zap corrections that are exactly at MJD 0 so they aren't fed through the Time mechanism and don't trigger ERFA warnings, but almost-zero we don't zap.

@dlakaplan dlakaplan mentioned this pull request Jun 28, 2022
dlakaplan added a commit to dlakaplan/PINT that referenced this pull request Jun 28, 2022
@aarchiba aarchiba added the awaiting review This PR needs someone to review it so it can be merged label Jun 28, 2022
@dlakaplan
Copy link
Contributor

This looks good to me. I'm happy to merge, or to wait until we discuss (not that there is much to discuss here).

@aarchiba
Copy link
Contributor Author

I think it's uncontroversial, so if you're happy please go ahead and merge.

@dlakaplan dlakaplan merged commit 496144a into nanograv:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants