Change update frequency for index.txt #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarchiba
added
awaiting review
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
=======================================
Coverage 61.64% 61.64%
=======================================
Files 89 89
Lines 20174 20174
Branches 3614 3614
=======================================
Hits 12436 12436
Misses 6961 6961
Partials 777 777
Continue to review full report at Codecov.
|
|
Seems straightforward to me. I can merge if you are ready. |
|
That would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.txtmust be checked to see what global clock corrections are available, whether old versions have been flagged as invalid, and how often other files should be checked for updates. That happens only if it is older than a certain amount. This amount was set to just a couple of minutes in the early stages of testing, but this PR sets it to 1 day. Longer would probably be fine.index.txtis a small file but if one has a flaky net connection getting it can be slow and annoying.