Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of typo fixes in comments and description strings #1348

Merged
merged 5 commits into from
Jul 27, 2022

Conversation

abhisrkckl
Copy link
Contributor

I am not adding a unit test because I have not changed any actual code. All the changes are in comments or description strings.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1348 (93f223c) into master (60e8871) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master    #1348   +/-   ##
=======================================
  Coverage   61.66%   61.66%           
=======================================
  Files          89       89           
  Lines       20233    20233           
  Branches     3646     3646           
=======================================
  Hits        12477    12477           
  Misses       6970     6970           
  Partials      786      786           
Impacted Files Coverage Δ
src/pint/models/absolute_phase.py 96.00% <ø> (ø)
src/pint/models/binary_ell1.py 80.95% <ø> (ø)
src/pint/models/dispersion_model.py 90.58% <ø> (ø)
src/pint/models/jump.py 83.48% <ø> (ø)
src/pint/models/model_builder.py 93.50% <ø> (ø)
src/pint/models/parameter.py 81.72% <0.00%> (ø)
src/pint/models/piecewise.py 100.00% <ø> (ø)
src/pint/models/priors.py 95.45% <ø> (ø)
src/pint/models/pulsar_binary.py 76.24% <ø> (ø)
src/pint/models/spindown.py 86.02% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e8871...93f223c. Read the comment docs.

@dlakaplan
Copy link
Contributor

is this ready to go?

@abhisrkckl
Copy link
Contributor Author

I think so. There are no changes to the actual code in this PR.

@dlakaplan dlakaplan merged commit 3df855d into nanograv:master Jul 27, 2022
@abhisrkckl abhisrkckl deleted the typo-fix branch July 27, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants